Skip to content

Simplify query now we've deleted withInheritedProgress#3478

Merged
robertbrignull merged 1 commit intomainfrom
robertbrignull/token-query
Mar 20, 2024
Merged

Simplify query now we've deleted withInheritedProgress#3478
robertbrignull merged 1 commit intomainfrom
robertbrignull/token-query

Conversation

@robertbrignull
Copy link
Copy Markdown
Contributor

We can simplify this query because it was written before #3466

Hopefully this will still work and cause zero change in alerts.

Checklist

  • CHANGELOG.md has been updated to incorporate all user visible changes made by this pull request.
  • Issues have been created for any UI or other user-facing changes made by this pull request.
  • [Maintainers only] If this pull request makes user-facing changes that require documentation changes, open a corresponding docs pull request in the github/codeql repo and add the ready-for-doc-review label there.

@robertbrignull robertbrignull requested a review from a team as a code owner March 14, 2024 16:04
@robertbrignull robertbrignull changed the title Simplify now we've deleted withInheritedProgress Simplify query now we've deleted withInheritedProgress Mar 14, 2024
Copy link
Copy Markdown
Contributor

@norascheuch norascheuch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👌

@robertbrignull
Copy link
Copy Markdown
Contributor Author

"progress bar" alerts in https://github.com/github/vscode-codeql/security/code-scanning?query=is%3Aopen+pr%3A3478 look the same as on main. Merging...

@robertbrignull robertbrignull merged commit e7d2a59 into main Mar 20, 2024
@robertbrignull robertbrignull deleted the robertbrignull/token-query branch March 20, 2024 11:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants